Java: Add the XGROUP CREATE and XGROUP DESTROY commands
#1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* JAVA: Add the XGROUP CREATE and DESTROY command Signed-off-by: Andrew Carbonetto <[email protected]> * Fix XGROUP DESTROY Signed-off-by: Andrew Carbonetto <[email protected]> * Clean up for self-review Signed-off-by: Andrew Carbonetto <[email protected]> * cargo fmt Signed-off-by: Andrew Carbonetto <[email protected]> * Change builder to use constructors Signed-off-by: Andrew Carbonetto <[email protected]> * Add optional javadocs Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
GumpacG
reviewed
Jun 14, 2024
java/client/src/main/java/glide/api/models/commands/stream/StreamGroupOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/stream/StreamGroupOptions.java
Show resolved
Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
GumpacG
approved these changes
Jun 15, 2024
Signed-off-by: Andrew Carbonetto <[email protected]>
| */ | ||
| @Builder.Default private boolean mkStream = false; | ||
|
|
||
| public static class StreamGroupOptionsBuilder { |
There was a problem hiding this comment.
Why do you need 2 builders? lines 30 and 15
There was a problem hiding this comment.
This will be the same builder. We're writing this infrastructure to add the makeStream() signature (without boolean).
There was a problem hiding this comment.
this means we can do StreamGroupOptions.builder().makeStream().build();
There was a problem hiding this comment.
It is confusing, but "It is not silly if it works" ©
There was a problem hiding this comment.
Lombok is the best
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
Yury-Fridlyand
approved these changes
Jun 17, 2024
Elen-Ghulam
approved these changes
Jun 17, 2024
jonathanl-bq
approved these changes
Jun 17, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 19, 2024
…o#1557) * Java: Add the `XGROUP CREATE` and `XGROUP DESTROY` commands (#359) * JAVA: Add the XGROUP CREATE and DESTROY command Signed-off-by: Andrew Carbonetto <[email protected]> * Fix XGROUP DESTROY Signed-off-by: Andrew Carbonetto <[email protected]> * Clean up for self-review Signed-off-by: Andrew Carbonetto <[email protected]> * cargo fmt Signed-off-by: Andrew Carbonetto <[email protected]> * Change builder to use constructors Signed-off-by: Andrew Carbonetto <[email protected]> * Add optional javadocs Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> * Update options to use builder Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> * Update doc Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
…o#1557) * Java: Add the `XGROUP CREATE` and `XGROUP DESTROY` commands (#359) * JAVA: Add the XGROUP CREATE and DESTROY command Signed-off-by: Andrew Carbonetto <[email protected]> * Fix XGROUP DESTROY Signed-off-by: Andrew Carbonetto <[email protected]> * Clean up for self-review Signed-off-by: Andrew Carbonetto <[email protected]> * cargo fmt Signed-off-by: Andrew Carbonetto <[email protected]> * Change builder to use constructors Signed-off-by: Andrew Carbonetto <[email protected]> * Add optional javadocs Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> * Update options to use builder Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> * Update doc Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds the following commands:
https://valkey.io/commands/xgroup-create/
https://valkey.io/commands/xgroup-destroy/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.