Java: add RANDOMKEY #1576
Merged
Java: add RANDOMKEY #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyip10
force-pushed
the
java/integ_cyip10_randomkey
branch
from
bbc2581 to
8ac8b21
Compare
acarbonetto
approved these changes
Jun 17, 2024
| @@ -112,4 +112,40 @@ public interface GenericClusterCommands { | |||
| * }</pre> | |||
| */ | |||
| CompletableFuture<Object[]> exec(ClusterTransaction transaction, SingleNodeRoute route); | |||
|
|
|||
| /** | |||
| * Returns a random key. <br> | |||
There was a problem hiding this comment.
Why don't we mentioned database in cluster mode?
Suggested change
| * Returns a random key. <br> | |
| * Returns a random key from the currently selected database. <br> |
There was a problem hiding this comment.
currently selected database is used for standalone (select command)
we can write about the routing that determents where are is the randomkey selected from
acarbonetto
reviewed
Jun 17, 2024
acarbonetto
force-pushed
the
java/integ_cyip10_randomkey
branch
from
c926c2e to
e2625bc
Compare
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
java/integ_cyip10_randomkey
branch
from
e2625bc to
159db27
Compare
Signed-off-by: Andrew Carbonetto <[email protected]>
cyip10
added a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 19, 2024
* RCT test * implement random val * work on SCT * implement randomkey no examples * current progress * implement randomKey * ran spotlessApply * addressed interface comment * progress on pause * address redis issue * add todo for redis rs issue * current progress address commentS * run into cluster error * ran into cluster error * address comments * address test comments * resolve merge conflicts * address cluster comment * Disable failing test until redis-rs fix in Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Chloe Yip <[email protected]> Co-authored-by: Chloe Yip <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
cyip10
added a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* RCT test * implement random val * work on SCT * implement randomkey no examples * current progress * implement randomKey * ran spotlessApply * addressed interface comment * progress on pause * address redis issue * add todo for redis rs issue * current progress address commentS * run into cluster error * ran into cluster error * address comments * address test comments * resolve merge conflicts * address cluster comment * Disable failing test until redis-rs fix in Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Chloe Yip <[email protected]> Co-authored-by: Chloe Yip <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://redis.io/docs/latest/commands/randomkey/
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.