support hsetnx, watch, type and unlink with GlideString #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
requested changes
Jun 24, 2024
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
eifrah-aws
reviewed
Jun 25, 2024
| @@ -161,8 +161,10 @@ public void unlink_multiple_keys(BaseClient client) { | |||
| setResult = client.set(key3, value).get(); | |||
| assertEquals(OK, setResult); | |||
|
|
|||
| Long unlinkedKeysNum = client.unlink(new String[] {key1, key2, key3}).get(); | |||
There was a problem hiding this comment.
As before: add GlideString, without removing String
eifrah-aws
requested changes
Jun 25, 2024
Yury-Fridlyand
approved these changes
Jun 26, 2024
java/integTest/src/test/java/glide/standalone/TransactionTests.java
Outdated
Show resolved
Hide resolved
java/integTest/src/test/java/glide/standalone/TransactionTests.java
Outdated
Show resolved
Hide resolved
added 2 commits
June 26, 2024 06:43
…ary integration test to use binary version calls
Comment on lines
315
to
318
| GlideString key1 = GlideString.gs("{key}-1" + UUID.randomUUID()); | ||
| GlideString key2 = GlideString.gs("{key}-2" + UUID.randomUUID()); | ||
| GlideString key3 = GlideString.gs("{key}-3" + UUID.randomUUID()); | ||
| GlideString key4 = GlideString.gs("{key}-4" + UUID.randomUUID()); |
There was a problem hiding this comment.
Import gs and shorten all calls
Suggested change
| GlideString key1 = GlideString.gs("{key}-1" + UUID.randomUUID()); | |
| GlideString key2 = GlideString.gs("{key}-2" + UUID.randomUUID()); | |
| GlideString key3 = GlideString.gs("{key}-3" + UUID.randomUUID()); | |
| GlideString key4 = GlideString.gs("{key}-4" + UUID.randomUUID()); | |
| GlideString key1 = gs("{key}-1" + UUID.randomUUID()); | |
| GlideString key2 = gs("{key}-2" + UUID.randomUUID()); | |
| GlideString key3 = gs("{key}-3" + UUID.randomUUID()); | |
| GlideString key4 = gs("{key}-4" + UUID.randomUUID()); |
Apply thoughout
See SharedCommandTests.java for reference
eifrah-aws
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support hsetnx, watch, type and unlink with GlideString