Java: Add LCS command (with IDX option)
#1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implemented LCS with IDX * TODO: add docs and more integTests * Added docs and remaining tests * Addressed comments * Fixed rust formatting * Addressed comments * Added WITHMATCHLEN apis * Expanded on example * Fixed rust ci failure * Removed LcsOptions * Improved examples in docs * Examples with different match lengths * Throw NPE if matches is not present
GumpacG
force-pushed
the
java/integ_guiang_lcs_II
branch
from
41b2ebb to
267f502
Compare
acarbonetto
approved these changes
Jun 26, 2024
jduo
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 28, 2024
* Java: Add `LCS` command (with IDX option) (#386) * Implemented LCS with IDX * TODO: add docs and more integTests * Added docs and remaining tests * Addressed comments * Fixed rust formatting * Addressed comments * Added WITHMATCHLEN apis * Expanded on example * Fixed rust ci failure * Removed LcsOptions * Improved examples in docs * Examples with different match lengths * Throw NPE if matches is not present * Resolved conflicts
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Implementing
LCSwith theIDXoption requires some glide core changes due to the complex objects returned.Return object of
LCS IDXwithoutWITHMATCHLENoption:Return object of
LCS IDXwithWITHMATCHLENoption:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.