Java: Rename RedisClient, RedisClusterClient to GlideClient, GlideClusterClient #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamazon
force-pushed
the
java/glideClient
branch
6 times, most recently
from
f080190 to
bd9ff88
Compare
shohamazon
force-pushed
the
java/glideClient
branch
4 times, most recently
from
0b70645 to
0dbe3c8
Compare
shohamazon
changed the title
shohamazon
force-pushed
the
java/glideClient
branch
from
0dbe3c8 to
e4f9b02
Compare
There was a problem hiding this comment.
Please also update https://github.com/aws/glide-for-redis/blob/e4f9b023dd6790ed5f7e280776695845601908c5/java/client/src/main/java/glide/api/BaseClient.java#L272
to
* @return a Future to connect and return a client.
| @@ -33,14 +33,14 @@ public void connectToRedis(ConnectionSettings connectionSettings) { | |||
| .useTLS(connectionSettings.useSsl) | |||
| .build(); | |||
| try { | |||
| redisClient = RedisClusterClient.CreateClient(config).get(10, SECONDS); | |||
| redisClient = GlideClusterClient.CreateClient(config).get(10, SECONDS); | |||
There was a problem hiding this comment.
rename the variable (line 20)
| // RedisClient. | ||
|
|
||
| // TODO: consider making connection manager static, and moving the | ||
| // ChannelHandler to the |
There was a problem hiding this comment.
Remove the linebreak please
| @@ -119,8 +119,8 @@ public void connection_request_protobuf_generation_default_cluster_configuration | |||
| @Test | |||
| public void connection_request_protobuf_generation_with_all_fields_set() { | |||
| // setup | |||
| RedisClientConfiguration redisClientConfiguration = | |||
| RedisClientConfiguration.builder() | |||
| GlideClientConfiguration redisClientConfiguration = | |||
There was a problem hiding this comment.
Rename the variable
| @@ -180,7 +180,7 @@ public void connection_request_protobuf_generation_with_all_fields_set() { | |||
| @Test | |||
| public void response_validation_on_constant_response_returns_successfully() { | |||
| // setup | |||
| RedisClientConfiguration redisClientConfiguration = RedisClientConfiguration.builder().build(); | |||
| GlideClientConfiguration redisClientConfiguration = GlideClientConfiguration.builder().build(); | |||
| @@ -197,7 +197,7 @@ public void response_validation_on_constant_response_returns_successfully() { | |||
| @Test | |||
| public void connection_on_empty_response_throws_ClosingException() { | |||
| // setup | |||
| RedisClientConfiguration redisClientConfiguration = RedisClientConfiguration.builder().build(); | |||
| GlideClientConfiguration redisClientConfiguration = GlideClientConfiguration.builder().build(); | |||
shohamazon
force-pushed
the
java/glideClient
branch
4 times, most recently
from
b660d14 to
b2ff58d
Compare
GilboaAWS
approved these changes
Jul 7, 2024
GilboaAWS
approved these changes
Jul 7, 2024
shohamazon
force-pushed
the
java/glideClient
branch
from
b2ff58d to
b04b27b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.