Java: Groom transaction docs and add some tests. #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-congo
reviewed
Jul 5, 2024
| * the <code>Transaction</code>. The response for each command depends on the executed Redis | ||
| * command. Specific response types are documented alongside each method. | ||
| * <p>Transaction Response: An <code>array</code> of command responses is returned by the client | ||
| * {@link RedisClient#exec} API, in the order they were given. Each element in the array represents |
There was a problem hiding this comment.
nit: in ClusterTransaction we use "command" instead of "API", which I think we can use here too
Suggested change
| * {@link RedisClient#exec} API, in the order they were given. Each element in the array represents | |
| * {@link RedisClient#exec} command, in the order they were given. Each element in the array represents |
There was a problem hiding this comment.
Our exec API doesn't 1:1 reflect command exec. What do you think?
There was a problem hiding this comment.
Maybe API then, should we use API in the other spots as well to be consistent? Not a big deal either way though
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
This was referenced Jul 5, 2024
Merged
aaron-congo
approved these changes
Jul 5, 2024
Yury-Fridlyand
force-pushed
the
java/integ_yuryf_groom_transaction
branch
from
b2680d4 to
c69fd39
Compare
Elen-Ghulam
approved these changes
Jul 6, 2024
acarbonetto
approved these changes
Jul 6, 2024
java/client/src/main/java/glide/api/models/ClusterTransaction.java
Outdated
Show resolved
Hide resolved
Yury-Fridlyand
force-pushed
the
java/integ_yuryf_groom_transaction
branch
from
7735b64 to
40790bd
Compare
yipin-chen
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
binaryOutputand how it is set (similar to scripts Java: store pointers in scripts #1795)@implNote(ref: Java txn: completed the remaining commands to support binary version #1777 and Changed the API to support binary transaction #1731)codetagsArgsBuilderfrom exportsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.