-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor update for node build #2393
Minor update for node build #2393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
But if we go for it already, I'd say we should do it as well for:
glide-logs
glide-rs.os-arch-libc-node
d.ts and js files in rust-client
proto files in src
And maybe in a separate that can be joined, clean all node stuff, lock.json, node_modules etc.
Maybe create a new issue to track the rest of the work that @avifenesh mentioned. I'm in favour of keeping PRs small, so I think this one is fine as is and the rest can be done in other PRs. |
That was actually a request to enrich |
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: BoazBD <[email protected]>
Allows to build node client on a fresh repo clone without addition voodoo.
npm install
is needed to avoid such errors(missing
protobufjs-cli
)