Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Implement Persist Command #2829

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Go: Implement Persist Command #2829

wants to merge 4 commits into from

Conversation

EdricCua
Copy link
Collaborator

@EdricCua EdricCua commented Dec 17, 2024 •
edited by janhavigupta007
Loading

Issue link

This Pull Request is linked to issue (URL): #2853

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@EdricCua EdricCua requested a review from a team as a code owner December 17, 2024 19:50
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Dec 17, 2024
janhavigupta007
janhavigupta007 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@janhavigupta007 janhavigupta007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint errors.

go/api/generic_commands.go Outdated Show resolved Hide resolved
@prateek-kumar-improving
Copy link
Collaborator

Please update changelog.md file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving left review comments

@janhavigupta007 janhavigupta007 janhavigupta007 approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EdricCua @prateek-kumar-improving @janhavigupta007 @Yury-Fridlyand