Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CD fixes nedded for Release 1.2.1 #2887

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

avifenesh
Copy link
Collaborator

@avifenesh avifenesh commented Dec 29, 2024

Issue link

This Pull Request is linked to issue #2885

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • [-] Tests are added or updated.
  • [-] CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@avifenesh avifenesh added this to the 1.2.1 milestone Dec 29, 2024
@avifenesh avifenesh requested a review from a team as a code owner December 29, 2024 09:53
@avifenesh avifenesh assigned avifenesh and ikolomi and unassigned avifenesh Dec 29, 2024
@ikolomi
Copy link
Collaborator

ikolomi commented Dec 29, 2024

The renaming of the folder was a quick hack to unblock the release.
No need to have it in the code - I have created a symlink 'actions-runner' to the new folder so no change is required.
I see there are addition changes besides the renaming, please make sure we still need them

@ikolomi ikolomi self-requested a review December 29, 2024 10:09
…etup for self-hosted runners

Signed-off-by: avifenesh <[email protected]>
@avifenesh avifenesh merged commit 151d9b1 into valkey-io:release-1.2 Dec 29, 2024
11 of 13 checks passed
@avifenesh avifenesh deleted the release1.2 branch December 29, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants