Enable refresh slots after reconnecting to initial nodes. #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as this operation is kind of resetting the client, so it should let it discover the whole topology before moving on the handle requests Signed-off-by: GilboaAWS <[email protected]>
barshaul
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
LGTM: The reason it was passed as ‘throttable’ was that we encountered this error not only when all connections were unavailable. We needed safety measures to ensure we didn’t overload the server. Since this has been fixed, and AllConnectionsUnavailable now serves only to 'reset' the client, this modification is appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to not throttle refresh slots after reconnecting to initial nodes, as this operation is kind of 'resetting' the client, so it should let it discover the whole topology before moving on to handle requests.