feat(url): Add skip_verify param #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 94.68% 94.68%
=======================================
Files 92 92
Lines 39096 39106 +10
=======================================
+ Hits 37019 37029 +10
Misses 1763 1763
Partials 314 314 ☔ View full report in Codecov by Sentry. |
rueian
reviewed
Dec 29, 2024
url.go
Outdated
Comment on lines
93
to
102
| if q.Get("skip_verify") == "" { | ||
| opt.TLSConfig.InsecureSkipVerify = true | ||
| } else { | ||
| skipVerify, err := strconv.ParseBool(q.Get("skip_verify")) | ||
| if err != nil { | ||
| return opt, fmt.Errorf("valkey: invalid skip verify: %q", q.Get("skip_verify")) | ||
| } | ||
| opt.TLSConfig.InsecureSkipVerify = skipVerify | ||
| } |
There was a problem hiding this comment.
Suggested change
| if q.Get("skip_verify") == "" { | |
| opt.TLSConfig.InsecureSkipVerify = true | |
| } else { | |
| skipVerify, err := strconv.ParseBool(q.Get("skip_verify")) | |
| if err != nil { | |
| return opt, fmt.Errorf("valkey: invalid skip verify: %q", q.Get("skip_verify")) | |
| } | |
| opt.TLSConfig.InsecureSkipVerify = skipVerify | |
| } | |
| if v := q.Get("skip_verify"); v == "" { | |
| opt.TLSConfig.InsecureSkipVerify = true | |
| } else { | |
| skipVerify, err := strconv.ParseBool(v) | |
| if err != nil { | |
| return opt, fmt.Errorf("valkey: invalid skip verify: %q", v) | |
| } | |
| opt.TLSConfig.InsecureSkipVerify = skipVerify | |
| } |
There was a problem hiding this comment.
LGTM mostly, but the indention on line 97 is wrong, and one minor improvement is you can store the result of q.Get() into a variable.
Add `skip_verify` or `skip_verify=true` to disable TLS certificate verification. Default is false. Inspired by various Go drivers: - ClickHouse: https://github.com/ClickHouse/clickhouse-go/blob/v2.30.0/clickhouse_options.go#L259 - MongoDB: https://github.com/mongodb/mongo-go-driver/blob/v2.0.0/x/mongo/driver/connstring/connstring.go#L609 - MySQL: https://github.com/go-sql-driver/mysql/blob/v1.8.1/dsn.go#L175 Signed-off-by: Julien Riou <[email protected]>
rueian
pushed a commit
that referenced
this pull request
Dec 29, 2024
Add `skip_verify` or `skip_verify=true` to disable TLS certificate verification. Default is false. Inspired by various Go drivers: - ClickHouse: https://github.com/ClickHouse/clickhouse-go/blob/v2.30.0/clickhouse_options.go#L259 - MongoDB: https://github.com/mongodb/mongo-go-driver/blob/v2.0.0/x/mongo/driver/connstring/connstring.go#L609 - MySQL: https://github.com/go-sql-driver/mysql/blob/v1.8.1/dsn.go#L175 Signed-off-by: Julien Riou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
skip_verifyorskip_verify=trueto disable TLS certificate verification. Default is false.Inspired by various Go drivers: