Make FUNCTION RESTORE FLUSH flush async based on lazyfree-lazy-user-flush #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lush FUNCTION RESTORE have a FLUSH option, it will delete all the existing libraries before restoring the payload. If for some reasons, there are a lot of libraries, we will block a while in here. Signed-off-by: Binbin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1254 +/- ##
============================================
+ Coverage 70.68% 70.69% +0.01%
============================================
Files 115 115
Lines 63177 63175 -2
============================================
+ Hits 44657 44664 +7
+ Misses 18520 18511 -9
|
Signed-off-by: Binbin <[email protected]>
ranshid
approved these changes
Nov 4, 2024
enjoy-binbin
commented
Nov 4, 2024
|
This doesn't look like a major change, i am going to merge it. @zuiderkwast do you want to take a quick look before i merge it? |
zuiderkwast
reviewed
Nov 21, 2024
Signed-off-by: Binbin <[email protected]>
…e_async Signed-off-by: Binbin <[email protected]>
zuiderkwast
reviewed
Nov 21, 2024
Signed-off-by: Binbin <[email protected]>
zuiderkwast
reviewed
Nov 21, 2024
Signed-off-by: Binbin <[email protected]>
zuiderkwast
approved these changes
Nov 21, 2024
enjoy-binbin
added
the
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FUNCTION RESTORE have a FLUSH option, it will delete all the existing
libraries before restoring the payload. If for some reasons, there are
a lot of libraries, we will block a while in here.
Adding a new functionsLibCtxFreeGeneric, it accepts a async parameter
to determine how to free the function ctx.