-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paused_purpose to INFO CLIENTS #1564
base: unstable
Are you sure you want to change the base?
Conversation
In valkey-io#1519, we added paused_actions and paused_timeout_milliseconds, it would be helpful if we add the paused_purpose since users also want to know the purpose for the pause. Signed-off-by: Binbin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1564 +/- ##
============================================
+ Coverage 70.78% 70.95% +0.16%
============================================
Files 120 120
Lines 65046 65077 +31
============================================
+ Hits 46045 46176 +131
+ Misses 19001 18901 -100
|
Signed-off-by: Binbin <[email protected]>
@@ -2714,7 +2714,8 @@ void pauseActions(pause_purpose purpose, mstime_t end, uint32_t actions); | |||
void unpauseActions(pause_purpose purpose); | |||
uint32_t isPausedActions(uint32_t action_bitmask); | |||
uint32_t isPausedActionsWithUpdate(uint32_t action_bitmask); | |||
mstime_t getPausedActionTimeout(uint32_t action); | |||
char *getPausedPurposeString(pause_purpose purpose); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing the String from function name getPausedPurposeString(), char* already represents the return type. I know in server.h, some function names keep the String even the return type is char*, and some do not. Let us keep simple and normalize it.
In #1519, we added paused_actions and paused_timeout_milliseconds,
it would be helpful if we add the paused_purpose since users also
want to know the purpose for the pause.
Currently available options: