init react-hooks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's add a README with the following:
I'll push an example below. |
|
Another potential consideration, if we're releasing the repo as a package - might be better to export hooks, context and lib as a class with arguments for custom RPC providers, proto server, etc - as opposed to exporting those folders raw. TLDR: It allows devs to control the package more easily. Other suggestions:
|
src/index.ts
Outdated
| @@ -0,0 +1,3 @@ | |||
| export * from './context'; | |||
| export * from './hooks'; | |||
There was a problem hiding this comment.
To support tree shaking (and prevent importing unnecessary hooks) its best to import each hook manually.
src/index.ts
Outdated
| @@ -0,0 +1,3 @@ | |||
| export * from './context'; | |||
There was a problem hiding this comment.
As discussed earlier, we should use export default ValoremProvider from "/..." for devs to config their RPCs, etc
This reverts commit 0ffaba4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements VAL-447
waiting on sdk v0.0.2-alpha.0