Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

featured instruments interface #48

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

megsdevs
Copy link
Contributor

No description provided.

Copy link

linear bot commented Jan 23, 2024

Copy link
Member

@0xAlcibiades 0xAlcibiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the one comment.

// Option id with created flag.
message Option {
H256 id = 1; // Option type encoded as option_id.
bool created = 2; // True if option type already exists with the clearing house.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also include all the details on the option here, and make it a hashmap of option details keyed on the ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants