Skip to content

Commit

Permalink
refactor: test method naming
Browse files Browse the repository at this point in the history
  • Loading branch information
@Karrenbelt
Karrenbelt committed Sep 2, 2022
1 parent 586e0df commit 7760ddc
Showing 1 changed file with 23 additions and 24 deletions.
47 changes: 23 additions & 24 deletions tests/test_skills/test_keep3r_job/test_behaviours.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@
AGENT_ADDRESS = "0x1Cc0771e65FC90308DB2f7Fd02482ac4d1B82A18"
SOME_CONTRACT_ADDRESS = "0xaed599aadfee8e32cedb59db2b1120d33a7bacfd"


DUMMY_RAW_TX: RawTx = {
"from": SOME_CONTRACT_ADDRESS,
"to": SOME_CONTRACT_ADDRESS,
Expand Down Expand Up @@ -161,7 +160,7 @@ def fast_forward(self, data: Optional[Dict[str, Any]] = None) -> None:
)
assert self.current_behaviour.behaviour_id == self.behaviour_class.behaviour_id

def mock_keep3r_v1_call(self, contract_callable: str, data: Any) -> None:
def mock_read_keep3r_v1(self, contract_callable: str, data: Any) -> None:
"""Mock keep3r V1 contract call"""

self.mock_contract_api_request(
Expand Down Expand Up @@ -199,9 +198,10 @@ def mock_keep3r_v1_raw_tx(self, contract_callable: str, data: Any) -> None:
),
)

def mock_test_job_call(self, contract_callable: str, data: Any) -> None:
"""Mock TestJob contract call"""
def mock_workable_call(self, data: bool) -> None:
"""Mock TestJob workable contract call"""

contract_callable = "workable"
self.mock_contract_api_request(
request_kwargs=dict(
performative=ContractApiMessage.Performative.GET_STATE,
Expand All @@ -218,7 +218,7 @@ def mock_test_job_call(self, contract_callable: str, data: Any) -> None:
),
)

def mock_build_work_tx_call(self, data: Any) -> None:
def mock_build_work_tx_call(self, data: RawTx) -> None:
"""Mock build work transaction"""

contract_callable = "build_work_tx"
Expand All @@ -233,12 +233,11 @@ def mock_build_work_tx_call(self, data: Any) -> None:
callable=contract_callable,
raw_transaction=ContractApiMessage.RawTransaction(
ledger_id="ethereum",
body={"data": data},
body={"data": data}, # type: ignore
),
),
)


def mock_build_safe_raw_tx(self) -> None:
"""Mock build safe raw transaction"""

Expand Down Expand Up @@ -289,7 +288,7 @@ class TestPathSelectionBehaviour(Keep3rJobFSMBehaviourBaseCase):
def test_blacklisted(self) -> None:
"""Test path_selection to blacklisted."""

self.mock_keep3r_v1_call("blacklist", True)
self.mock_read_keep3r_v1("blacklist", True)
self.mock_a2a_transaction()
self._test_done_flag_set()
self.end_round(done_event=Event.BLACKLISTED)
Expand All @@ -299,7 +298,7 @@ def test_blacklisted(self) -> None:
def test_insufficient_funds(self) -> None:
"""Test path_selection to insufficient funds."""

self.mock_keep3r_v1_call("blacklist", False)
self.mock_read_keep3r_v1("blacklist", False)
self.mock_ethereum_get_balance(amount=-1)
self.mock_a2a_transaction()
self._test_done_flag_set()
Expand All @@ -309,9 +308,9 @@ def test_insufficient_funds(self) -> None:
def test_not_bonded(self) -> None:
"""Test path_selection to not bonded."""

self.mock_keep3r_v1_call("blacklist", False)
self.mock_read_keep3r_v1("blacklist", False)
self.mock_ethereum_get_balance(amount=0)
self.mock_keep3r_v1_call("bondings", 0)
self.mock_read_keep3r_v1("bondings", 0)
self.mock_a2a_transaction()
self._test_done_flag_set()
self.end_round(done_event=Event.NOT_BONDED)
Expand All @@ -320,10 +319,10 @@ def test_not_bonded(self) -> None:
def test_not_activated(self) -> None:
"""Test path_selection to not activated."""

self.mock_keep3r_v1_call("blacklist", False)
self.mock_read_keep3r_v1("blacklist", False)
self.mock_ethereum_get_balance(amount=0)
self.mock_keep3r_v1_call("bondings", 1)
self.mock_keep3r_v1_call("BOND", 3 * SECONDS_PER_DAY)
self.mock_read_keep3r_v1("bondings", 1)
self.mock_read_keep3r_v1("BOND", 3 * SECONDS_PER_DAY)
self.mock_get_latest_block(block={"timestamp": 0})
self.mock_a2a_transaction()
self._test_done_flag_set()
Expand All @@ -333,10 +332,10 @@ def test_not_activated(self) -> None:
def test_healthy(self) -> None:
"""Test path_selection to healthy."""

self.mock_keep3r_v1_call("blacklist", False)
self.mock_read_keep3r_v1("blacklist", False)
self.mock_ethereum_get_balance(amount=0)
self.mock_keep3r_v1_call("bondings", 1)
self.mock_keep3r_v1_call("BOND", 3 * SECONDS_PER_DAY)
self.mock_read_keep3r_v1("bondings", 1)
self.mock_read_keep3r_v1("BOND", 3 * SECONDS_PER_DAY)
self.mock_get_latest_block(block={"timestamp": 3 * SECONDS_PER_DAY + 1})
self.mock_a2a_transaction()
self._test_done_flag_set()
Expand Down Expand Up @@ -369,8 +368,8 @@ class TestWaitingBehaviour(Keep3rJobFSMBehaviourBaseCase):
def test_waiting(self) -> None:
"""Test waiting"""

self.mock_keep3r_v1_call("bondings", 0)
self.mock_keep3r_v1_call("BOND", 1)
self.mock_read_keep3r_v1("bondings", 0)
self.mock_read_keep3r_v1("BOND", 1)
self.mock_get_latest_block(block={"timestamp": 2})
self.mock_a2a_transaction()
self._test_done_flag_set()
Expand Down Expand Up @@ -403,7 +402,7 @@ class TestGetJobsBehaviour(Keep3rJobFSMBehaviourBaseCase):
def test_get_jobs(self) -> None:
"""Test get_jobs."""

self.mock_keep3r_v1_call("get_jobs", ["some_job_address"])
self.mock_read_keep3r_v1("get_jobs", ["some_job_address"])
self.mock_a2a_transaction()
self._test_done_flag_set()
self.end_round(done_event=Event.DONE)
Expand All @@ -419,6 +418,7 @@ def test_run(self) -> None:
"""Test perform work."""

self.mock_build_work_tx_call(DUMMY_RAW_TX)
self.mock_build_safe_raw_tx()
self.mock_a2a_transaction()
self._test_done_flag_set()
self.end_round(done_event=Event.WORK_TX)
Expand Down Expand Up @@ -462,8 +462,7 @@ def test_is_workable(
) -> None:
"""Test is_workable."""

self.mock_test_job_call("workable", is_workable)
self.mock_build_safe_raw_tx()
self.mock_workable_call(is_workable)
self.behaviour.act_wrapper()
self.mock_a2a_transaction()
self._test_done_flag_set()
Expand All @@ -488,7 +487,7 @@ def test_is_profitable(
) -> None:
"""Test is_profitable."""

self.mock_keep3r_v1_call("credits", credits)
self.mock_read_keep3r_v1("credits", credits)
self.behaviour.act_wrapper()
self.mock_a2a_transaction()
self._test_done_flag_set()
Expand All @@ -514,5 +513,5 @@ def test_top_up(
self.behaviour.act_wrapper()
self.mock_a2a_transaction()
self._test_done_flag_set()
self.end_round(done_event=Event.TOP_UP)
self.end_round(done_event=event)
assert self.current_behaviour.behaviour_id == next_round.round_id

0 comments on commit 7760ddc

Please sign in to comment.