Fix performatives #106
Merged
Fix performatives #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Karrenbelt
commented
Sep 2, 2022
Comment on lines
+265
to
+266
| if blacklisted is None: | ||
| return None |
There was a problem hiding this comment.
instead of bubbling up None we could consider raising a custom error.
There was a problem hiding this comment.
The whole error treatment you have introduced is inconsistent. But I will now merge this as we want to wrap up.
There was a problem hiding this comment.
added to issue #98
Comment on lines
+522
to
+525
| work_tx = yield from self.build_safe_raw_tx(raw_tx) | ||
| if work_tx is None: | ||
| yield from self.sleep(self.context.params.sleep_time) | ||
| return |
There was a problem hiding this comment.
Note, if this returns then we unnecessarily take 517 again. It would be desirable to store locally on behaviour until it either succeeds or gets excited.
DavidMinarsch
approved these changes
Sep 4, 2022
Tests/performatives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Behaviours have been revisited as it was pointed out that dealing with message performatives was not sufficiently covered #98. When the response is of an incorrect type (e.g. on error) we cannot return.
build_safe_raw_txwas not yet in useIn this PR we update behaviours to deal with
Optionalreturnshelper functions introduced:
build_keep3r_raw_txis_workable_jobbuild_work_raw_txsafe transaction building step added for:
BondingBehaviourActivationBehaviourPerformWorkBehaviour