-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax deps #2223
base: main
Are you sure you want to change the base?
Relax deps #2223
Conversation
@kongzii Are you still working on relaxing the dependencies here? If so would you mind adding At it looks to be pinned at;
If we could get this changed it would be great. Not even sure why where using semver! :) |
@8ball030 Just waiting for review and hopefully merge+release. Last commit was just to fix the docker version that was mentioned in a review elsewhere. Could you clarify what you mean? I don't see any semver listed in dependencies. Maybe it's a subdependency of something? |
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
x
in the box that appliesChecklist
Put an
x
in the boxes that apply.main
branch (left side). Also you should start your branch off ourmain
.Further comments
Locally I'm getting this error while running
make common-checks-2
but that shouldn't be related to my changes.I tried to install
grpcio
directly from pip, I tried upgrading of pip, installing-dev
version of python, but so far nothing, do you have experience in running this on Mac with M2 please?