Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SDK v3 #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update to SDK v3 #32

wants to merge 3 commits into from

Conversation

autopulated
Copy link

@autopulated autopulated commented Dec 20, 2023

Opening PR as requested #31 (comment)

Issues that need resolving still:

  • the -sdkv3 suffix from the fork needs removing
  • what to do about version numbers (keep on v4, or change?)
  • behaviour of getParameter for a nonexistent parameter name needs to be resolved

@neo-peter-spangler
Copy link

please

@autopulated
Copy link
Author

I've tested getParameter against a nonexistent parameter in aws, and both the sdk-v2 and the sdk-v3 versions throw a "ParameterNotFound" error, so I don't think that should block merging this. The identity of the thrown error type is obviously different, and it has different details, and that might justify releasing this as a new major version.

(The plural getParameters version also returns a response with both .Parameters and .InvalidParameters in both cases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants