Small bugfixes and some new functionality #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With it it's possible to do concurrent searches
After 1305fc "Fix string overrun bugs in nvp.c" a header such as
"Content-Type: text/html; charset=utf-8;" (note trailing semicolon)
creates a struct nvp {type=NVP_NAMEVALUE, lhs=NULL, rhs=NULL} and
causes a segmentation fault afterwards when those pointers are used.
Also unconditionally free temporal values, free(NULL) is valid.
|
Hello Jaime Velasco Juan, Thank you very much for these changes, especially the one for the bug I introduced myself recently ("Never create nvp with NULL lhs or rhs"). I merged all of them except for the --no-lock one. The --no-lock one, I plan to resolve by instead removing the locking altogether. There are a couple of open issues about that: rc0#21 and rc0#25. That will be for the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've been using a patched mairix for a few years and I'd like to see if the changes are wanted upstream (I should have sent them years ago...)
I use mairix in a small webpage to let a few people search a big shared mailbox, so there is a commit to skip database locking (we do the update in a copy of the database and update it atomically when finished). The commit to show In-Reply-To header lets us reconstruct the thread summary without having to open and parse each mail in the webapp.
Then there are a couple bugfixes for problems surfaced with our use across several years and lots of weird mail.
Regards