-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ErrorBoundary component with tests and LoadingSpinner #115
base: master
Are you sure you want to change the base?
Add ErrorBoundary component with tests and LoadingSpinner #115
Conversation
@Swayam-code is attempting to deploy a commit to the vansh-codes1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
Please resolve the conficts @Swayam-code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolve conflicts and good to merge!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hii @Swayam-code , did you fix the error? |
give me a day. I'm working on it |
Okay sure @Swayam-code |
…t tests 1. Error Boundaries: - Add ErrorBoundary component with proper error handling and UI - Implement retry functionality - Add tests with 100% coverage 2. Loading States: - Replace global loading state with individual states - Add separate loading indicators for profile, repos, tagline, and canvas 3. Input Validation: - Add configValidation utility - Validate required fields, data types, and value ranges - Add tests with 95.65% coverage 4. Unit Tests: - Add tests for ErrorBoundary (100% coverage) - Add tests for UserCard (96.15% coverage) - Add tests for config validation (95.65% coverage)
@vansh-codes This PR adds several improvements to enhance error handling, user experience, and code quality: 1. Error Boundaries
2. Loading States
3. Input Validation
4. Unit Tests
Changes Made
Test Coverage
Build Status
|
The error still persists buddy! you removed next/babel which is important as per my knowledge is it working in localhost for you? |
Fixes the issue and Closes #111
Key Benefits of These Changes:
Better Error Handling:
Improved User Experience:
Data Validation:
Testing Infrastructure: