-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add try-catch, for, while, while do, and enum, and fix if #60
base: main
Are you sure you want to change the base?
Conversation
There's some odd behavior where when trying to do the range operator on two ints, the grammar thinks it's a float: |
I have also yet to figure out the best way to do array comprehension, accounting for |
it may be worth looking into https://tree-sitter.github.io/tree-sitter/creating-parsers#external-scanners for the range operator/floats, the regex for the floats would be hard to get right |
"fixed" the range expression for now. Still really confused on how to deal with the conditional operator thing. Looks like it conflicts with |
Instead of having specific constructs for array comprehensions, perhaps for/while should be allowed as a generic "expression" element, and expressions should be allowed within |
Fixing this regex may solve the float problem: tree-sitter-haxe/grammar-literals.js Line 12 in 12e814c
Right now it accepts any number of |
Hi! Was working on Helix support for the queries when I realized the grammar hadn't implemented these structures. Figured I'd have a go at it. First time playing around with treesitter so things probably aren't ideal but it mostly works. I still also need to get tests passing and write some tests