-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift Testing #14
Swift Testing #14
Conversation
fpseverino
commented
Oct 11, 2024
- Switch from XCTest to Swift Testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 96.35% 96.40% +0.04%
==========================================
Files 32 34 +2
Lines 1153 1167 +14
==========================================
+ Hits 1111 1125 +14
Misses 42 42
|
Tests/PassesTests/withApp.swift
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth moving this into a separate module to avoid duplicating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The withApp
functions pass to the closure not only the Application
, but also a PassesService
or OrdersService
(which don't share a common protocol) which are also used to set up model middleware and migrations, so most of the code in these functions can't be unified