Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed missing s as per Python string expression syntax #990

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

asnov
Copy link
Contributor

@asnov asnov commented Jul 4, 2024

supervisord uses the Python string expression syntax in its configuration files, like this %(ENV_X)s
It's described here: http://supervisord.org/configuration.html#environment-variables
In the "Deploy->Supervisor->Configure" section of the documentation the final "s" were omitted:
https://docs.vapor.codes/deploy/supervisor/#configure
so copy-pasting this example was leading to wrong file names of the logs.
For example, instead of the expected file name hello-stdout.log I had the wrong hellotdout.log.

@asnov asnov requested review from a team, 0xTim and gwynne as code owners July 4, 2024 02:16
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim added the no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work) label Jul 4, 2024
@0xTim 0xTim enabled auto-merge (squash) July 4, 2024 12:11
@0xTim 0xTim merged commit e6dcb13 into vapor:main Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants