Add Meter for in-progress jobs #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptoffy
commented
Nov 25, 2024
| Timer( | ||
| label: "\(jobName).jobDurationTimer", | ||
| label: "\(jobName).duration.timer", |
There was a problem hiding this comment.
Not sure if this can be considered a breaking change, but people who use this might have to switch
There was a problem hiding this comment.
I think this would break integrations. SemVer wise it's technically fine but it could cause issues. We're not actually changing any information here right? Though the display unit was incorrect before right?
@maciejtrybilo you're using this correct?
| dimensions: [ | ||
| ("success", error == nil ? "true" : "false"), | ||
| ("jobName", jobName), | ||
| ], | ||
| preferredDisplayUnit: .seconds | ||
| preferredDisplayUnit: .milliseconds |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 84.48% 84.57% +0.08%
==========================================
Files 22 22
Lines 709 765 +56
==========================================
+ Hits 599 647 +48
- Misses 110 118 +8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
Metermetric to record the number of jobs currently being processed by a worker.The gauge also allows calculation of not yet processed but enqueued jobs, since we can now do