Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved NE scheme to address known issues #22

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

khumnath
Copy link
Contributor

improved some transliteration schemes.
this scheme can be used in all devnagari script based languages with some modifications.

@agx
Copy link
Contributor

agx commented Aug 31, 2024

Tests pass now 👍

I think you can enable them again in .github/workflows/build.yml by removing the TestNe| there. This would make sure we don't accidentally regress.

@khumnath
Copy link
Contributor Author

@agx The test will not pass with the current Ruby test file. The acceptCondition in Varnam does not handle multiple characters at this time. For example, in 'baagh' => 'बाघ', the sequence gh should return where gh is mapped to with :accept_if => :ends_with, so it should return but returns घ्.

@agx
Copy link
Contributor

agx commented Aug 31, 2024

Ah, I see it too now:

  2) Failure:
TestNe#test_words [/var/scratch/librem5/varnam-schemes/test/ne.rb:26]:
Expected: "बाघ"
  Actual: "बाघ्"

Thanks @khumnath . Seems I hadn't rebuilt the vst properly before.

@subins2000 subins2000 merged commit 96d3182 into varnamproject:master Sep 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants