add indic number enable switch, enable input wordbreak keys #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laerning function need to refine with this change.
* numbers should not be wordToLearn.
* other wordBreak keys also should not be wordToLearn.
added ```if (isWordBreakKey) {
// Remove the word break character for learning
wordToLearn = wordToLearn.substr(0, wordToLearn.size() - 1);
}``` but not working i think.
anoopmsivadas
requested changes
Jul 29, 2024
khumnath
commented
Jul 30, 2024
anoopmsivadas
requested changes
Aug 15, 2024
anoopmsivadas
requested changes
Oct 12, 2024
There was a problem hiding this comment.
Hi @khumnath, few comments are not addressed I believe, can you check once. Thanks!
I have commented on previous requests as I made changes, but I’m not sure where you are expecting my comment to address your request. |
discussed here varnamproject#11 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
learning function need to refine with this change.
added
if (isWordBreakKey) { // Remove the word break character for learning wordToLearn = wordToLearn.substr(0, wordToLearn.size() - 1); }but not working i think.