Skip to content

Commit

Permalink
Change default encoding to utf-8 from cp1252.
Browse files Browse the repository at this point in the history
cp1252 is a superset of iso-8859-1. I don't think it is a good default value.
See koxudaxi#334 (comment)
Fixed koxudaxi#334
  • Loading branch information
yyamano committed Aug 23, 2023
1 parent 0b33866 commit 0210350
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fastapi_code_generator/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def dynamic_load_module(module_path: Path) -> Any:

@app.command()
def main(
encoding: str = typer.Option("cp1252", "--encoding", "-e"),
encoding: str = typer.Option("utf-8", "--encoding", "-e"),
input_file: str = typer.Option(..., "--input", "-i"),
output_dir: Path = typer.Option(..., "--output", "-o"),
model_file: str = typer.Option(None, "--model-file", "-m"),
Expand Down

0 comments on commit 0210350

Please sign in to comment.