-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated SelectField
AntD tests to @testing-library/react
#1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Core
Affects the uniforms package
Area: Theme
Affects some of the theme packages
Theme: AntD
Affects the uniforms-antd package
labels
Mar 23, 2024
kestarumper
force-pushed
the
select-field-tests-antd
branch
from
March 23, 2024 16:36
748eb33
to
c7a9c37
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## select-field-tests #1312 +/- ##
===================================================
Coverage 94.60% 94.61%
===================================================
Files 231 231
Lines 3821 3823 +2
Branches 1029 1030 +1
===================================================
+ Hits 3615 3617 +2
Misses 82 82
Partials 124 124 ☔ View full report in Codecov by Sentry. |
piotrpospiech
approved these changes
Mar 29, 2024
zendranm
approved these changes
Mar 29, 2024
zaxovaiko
approved these changes
Mar 29, 2024
kestarumper
changed the title
Enable AntD SelectField tests suite
Migrated Apr 7, 2024
SelectField
AntD tests to @testing-library/react
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Core
Affects the uniforms package
Area: Theme
Affects some of the theme packages
Theme: AntD
Affects the uniforms-antd package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered a lot of problems. Many related to
fireEvent.change
not working at all. AntD seems to be doing things differently when it comes to therole
etc. It also does some virtualization which makes things harder.Notes
combobox
fireEvent.click
, it has to befireEvent.mouseDown
(see references)Reference