-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated wrapField
tests to @testing-library/react
#1318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR really points out the disadvantage of the suites approach (the same as SelectField
suites, I guess)
- We talked we don't want to create flags for specific themes, but I see why it is needed here.
- Creating tests only for one theme in the suite or changing the
expect
check for the specific theme only makes this suite harder to read.
I think we need to consider keeping theme-specific tests in a separate file. We could keep core tests in the suites and keep theme specific in the theme package or create a separate file (we can have wrapField
as a directory). The distinction can be necessary as we support different props, e.g., validateStatus
in the AntD theme.
The same issue is true for the rest of the tests that are waiting to be moved to suites (mainly AntD and MUI).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1318 +/- ##
==========================================
- Coverage 94.55% 94.32% -0.24%
==========================================
Files 231 229 -2
Lines 3823 3754 -69
Branches 1030 1011 -19
==========================================
- Hits 3615 3541 -74
+ Misses 82 81 -1
- Partials 126 132 +6 ☔ View full report in Codecov by Sentry. |
Is part of #1130