Log step progress in verbose mode #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In verbose mode, the primary log is mostly generated by the executed commands (Configure, Build, Stub Generation steps). However, it is currently not obvious that more steps, e.g. a Clean step, are executed as well. Log each step when it starts to provide a summary of the current JIT compile progress.
In the future, the currently quite static log of steps could be shortened to indicate that steps were skipped. For this, the status and condition logic could become first-class behavior of a step which would come with the benefit of natively having a persistent state for each step.