-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyproject(ruff): Add pydocstyle rule selector w/ numpy convention #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd2711f
to
1189fbd
Compare
6b0aae2
to
ec70ec8
Compare
`ruff --show-fixes --fix-only .` Fixed 5 errors: - src/vcspull/exc.py: 1 × D211 (blank-line-before-class) - src/vcspull/log.py: 1 × D202 (no-blank-line-after-function) - src/vcspull/util.py: 1 × D202 (no-blank-line-after-function) - tests/helpers.py: 1 × D211 (blank-line-before-class) - tests/test_sync.py: 1 × D202 (no-blank-line-after-function) Fixed 5 errors (8 additional fixes available with `--unsafe-fixes`).
`ruff --show-fixes --fix-only --unsafe-fixes .` Fixed 8 errors: - docs/conf.py: 1 × D400 (ends-in-period) - src/vcspull/_internal/config_reader.py: 1 × D400 (ends-in-period) - src/vcspull/config.py: 1 × D400 (ends-in-period) - tests/test_repo.py: 3 × D400 (ends-in-period) - tests/test_sync.py: 2 × D400 (ends-in-period) Fixed 8 errors.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 16 16
Lines 935 935
Branches 180 180
=======================================
Hits 794 794
Misses 90 90
Partials 51 51 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appendix