Use future annotations #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
==========================================
- Coverage 84.33% 84.11% -0.23%
==========================================
Files 16 16
Lines 932 919 -13
Branches 137 137
==========================================
- Hits 786 773 -13
Misses 93 93
Partials 53 53 ☔ View full report in Codecov by Sentry. |
Fixed 134 errors:
- conftest.py:
1 × TC003 (typing-only-standard-library-import)
1 × I002 (missing-required-import)
- docs/conf.py:
2 × UP037 (quoted-annotation)
1 × I002 (missing-required-import)
1 × I001 (unsorted-imports)
1 × UP007 (non-pep604-annotation)
- scripts/generate_gitlab.py:
1 × I001 (unsorted-imports)
1 × TC001 (typing-only-first-party-import)
1 × I002 (missing-required-import)
- src/vcspull/__about__.py:
1 × I002 (missing-required-import)
- src/vcspull/__init__.py:
1 × I001 (unsorted-imports)
1 × I002 (missing-required-import)
- src/vcspull/_internal/config_reader.py:
8 × UP037 (quoted-annotation)
1 × I001 (unsorted-imports)
1 × I002 (missing-required-import)
- src/vcspull/cli/__init__.py:
2 × UP007 (non-pep604-annotation)
1 × I002 (missing-required-import)
- src/vcspull/cli/sync.py:
3 × TC003 (typing-only-standard-library-import)
2 × UP007 (non-pep604-annotation)
2 × TC002 (typing-only-third-party-import)
1 × I002 (missing-required-import)
1 × I001 (unsorted-imports)
- src/vcspull/config.py:
17 × UP007 (non-pep604-annotation)
8 × UP037 (quoted-annotation)
1 × I002 (missing-required-import)
1 × TC003 (typing-only-standard-library-import)
1 × I001 (unsorted-imports)
- src/vcspull/exc.py:
1 × I002 (missing-required-import)
- src/vcspull/log.py:
1 × UP007 (non-pep604-annotation)
1 × I002 (missing-required-import)
- src/vcspull/types.py:
3 × UP007 (non-pep604-annotation)
3 × TC002 (typing-only-third-party-import)
1 × TC003 (typing-only-standard-library-import)
1 × I002 (missing-required-import)
1 × I001 (unsorted-imports)
- src/vcspull/util.py:
1 × I002 (missing-required-import)
- src/vcspull/validator.py:
1 × I002 (missing-required-import)
1 × UP037 (quoted-annotation)
- tests/__init__.py:
1 × I002 (missing-required-import)
- tests/fixtures/example.py:
1 × I002 (missing-required-import)
1 × UP037 (quoted-annotation)
- tests/helpers.py:
1 × UP037 (quoted-annotation)
1 × TC003 (typing-only-standard-library-import)
1 × I002 (missing-required-import)
1 × I001 (unsorted-imports)
1 × PYI034 (non-self-return-type)
- tests/test_cli.py:
24 × UP037 (quoted-annotation)
1 × TC003 (typing-only-standard-library-import)
1 × I002 (missing-required-import)
1 × TC002 (typing-only-third-party-import)
1 × I001 (unsorted-imports)
- tests/test_config.py:
2 × UP037 (quoted-annotation)
1 × I002 (missing-required-import)
1 × UP007 (non-pep604-annotation)
1 × TC003 (typing-only-standard-library-import)
1 × I001 (unsorted-imports)
- tests/test_config_file.py:
1 × I002 (missing-required-import)
- tests/test_repo.py:
1 × I001 (unsorted-imports)
1 × TC003 (typing-only-standard-library-import)
1 × I002 (missing-required-import)
- tests/test_sync.py:
1 × I002 (missing-required-import)
1 × TC003 (typing-only-standard-library-import)
1 × TC002 (typing-only-third-party-import)
1 × I001 (unsorted-imports)
- tests/test_utils.py:
3 × I001 (unsorted-imports)
1 × TC003 (typing-only-standard-library-import)
1 × I002 (missing-required-import)
1 × TC002 (typing-only-third-party-import)
Found 460 errors (134 fixed, 326 remaining).
20 files reformatted, 5 files left unchanged
uv run ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; uv run ruff format .
tony
force-pushed
the
future-annotations
branch
from
815643e to
240fbb0
Compare
tony
force-pushed
the
future-annotations
branch
from
221ded1 to
eb80806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
chore: Support PEP 563
from __future__ import annotationsUsing PEP 563's deferred resolution of annotations avoids the computation cost of symbols we imported solely used for type-checking.
Ruff:
non-pep585-annotation (UP006)non-pep604-annotation (UP007)PEP 563: https://peps.python.org/pep-0563/