Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable format PR creation #2213

Closed
wants to merge 3 commits into from
Closed

Disable format PR creation #2213

wants to merge 3 commits into from

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Oct 18, 2023

Description:

WHAT

This PR contains the following changes

  • Disable format PR creation
  • helm-docs installation URL

WHY

When currently unformatted PR is merged, a format PR is automatically created.
In the future, the format should always be done before PR is merged (using Require status checks), so automatic creation should be disabled.

Also, the ci-container build was failing in the main branch, so I fixed it in this PR.

Related Issue:

Versions:

  • Go Version: 1.21.3
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@hlts2 hlts2 self-assigned this Oct 18, 2023
@hlts2 hlts2 requested review from a team, kpango and datelier and removed request for a team October 18, 2023 09:31
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 requested a review from vankichi October 18, 2023 09:32
@hlts2 hlts2 closed this Oct 18, 2023
@hlts2 hlts2 deleted the fix/ci/format-job-logic branch October 18, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants