Add offset shift vector check #2818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
size/S
type/bug
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/e2e/operation/stream.go (1)
1151-1155: LGTM! Consider enhancing the error message.The implementation correctly handles the offset shift vector check by comparing against the original vector and its shifted variations. However, the error message could be more informative.
Consider improving the error message to indicate which variation was expected to match:
- t.Errorf( - "got: %#v, expected: %#v", - resp.GetVector(), - ds.Train[idx], - ) + t.Errorf( + "got: %#v, expected one of:\noriginal: %#v\nshift1: %#v\nshift2: %#v", + resp.GetVector(), + v, + append(v[1:], v[:1]...), + append(v[2:], v[:2]...), + )
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/e2e/operation/stream.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (41)
- GitHub Check: dump-contexts-to-log
- GitHub Check: dump-contexts-to-log
- GitHub Check: dump-contexts-to-log
- GitHub Check: dump-contexts-to-log
- GitHub Check: dump-contexts-to-log
- GitHub Check: detect-ci-container / detect
- GitHub Check: dump-contexts-to-log
- GitHub Check: dump-contexts-to-log
- GitHub Check: detect-ci-container / detect
- GitHub Check: dump-contexts-to-log
- GitHub Check: dump-contexts-to-log
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: dump-contexts-to-log
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: dump-contexts-to-log
- GitHub Check: detect-ci-container / detect
- GitHub Check: dump-contexts-to-log
- GitHub Check: dump-contexts-to-log
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: dump-contexts-to-log
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: dump-contexts-to-log
- GitHub Check: detect-ci-container / detect
- GitHub Check: detect-ci-container / detect
- GitHub Check: dump-contexts-to-log
- GitHub Check: E2E test (Stream CRUD) for operator
- GitHub Check: E2E test (Stream CRUD)
- GitHub Check: detect-ci-container / detect
- GitHub Check: dump-contexts-to-log
Profile Report
|
Profile Report
|
vankichi
changed the title
Deploying vald with
|
| Latest commit: |
586b933
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23c8dd51.vald.pages.dev |
| Branch Preview URL: | https://bugfix-e2e-add-getobject-off.vald.pages.dev |
kmrmt
requested review from
a team,
vankichi and
datelier
and removed request for
a team
vankichi
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SSIA
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit