Backport PR #2819 to release/v1.7 for Fix docker build error (benchmark-job, loadtest) #2826

vdaas-ci · 2025-01-31T04:16:03Z

Description

SSIA

Related Issue

Versions

Vald Version: v1.7.16
Go Version: v1.23.5
Rust Version: v1.83.0
Docker Version: v27.4.0
Kubernetes Version: v1.32.0
Helm Version: v3.16.3
NGT Version: v2.3.5
Faiss Version: v1.9.0

Checklist

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Summary by CodeRabbit

Dependency Management
- Removed libhdf5-dev package from multiple Dockerfiles across different project environments
- Updated installation process in Makefile to include ldconfig after HDF5 installation to refresh dynamic linker cache

* 💚 Add libcurl4-openssl-dev Signed-off-by: vankichi <[email protected]> * ♻️ Remove apt get libhd5-dev Signed-off-by: vankichi <[email protected]> --------- Signed-off-by: vankichi <[email protected]>

cloudflare-workers-and-pages · 2025-01-31T04:16:04Z

Deploying vald with Cloudflare Pages

Latest commit:	`712fada`
Status:	✅ Deploy successful!
Preview URL:	https://2d320796.vald.pages.dev
Branch Preview URL:	https://backport-release-v1-7-bugfix-wdgl.vald.pages.dev

View logs

coderabbitai · 2025-01-31T04:16:11Z

📝 Walkthrough

Walkthrough

The pull request involves modifications across multiple Dockerfiles and a Makefile, primarily focusing on the removal of libhdf5-dev package installations and updating the HDF5 installation process. In the Makefile.d/tools.mk, an ldconfig command is added to the HDF5 installation target to update the dynamic linker cache. Simultaneously, the libhdf5-dev package is removed from several Docker container build configurations, including base CI, development, example client, benchmark job, and CLI loadtest environments.

Changes

File	Change Summary
`Makefile.d/tools.mk`	Added `&& ldconfig` to `hdf5/install` target to update dynamic linker cache
`dockers/ci/base/Dockerfile`	Removed `libhdf5-dev` package installation
`dockers/dev/Dockerfile`	Removed `libhdf5-dev` package installation
`dockers/example/client/Dockerfile`	Removed `libhdf5-dev` package installation
`dockers/tools/benchmark/job/Dockerfile`	Removed `libhdf5-dev` package installation
`dockers/tools/cli/loadtest/Dockerfile`	Removed `libhdf5-dev` package installation

Possibly related PRs

Fix docker build error (benchmark-job, loadtest) #2819: Modifies the hdf5/install target in Makefile.d/tools.mk by appending && ldconfig to update the dynamic linker cache

Suggested Labels

type/bug, priority/medium, size/S, area/makefile, actions/backport/release/v1.7

Suggested Reviewers

vankichi
kpango

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

Makefile.d/tools.mk (1)

262-263: LGTM! The addition of ldconfig is essential for proper library linking.

The addition of ldconfig ensures that the dynamic linker cache is updated after installing HDF5 from source. This is particularly important in the context of Docker builds, as it helps resolve library loading issues that may occur when transitioning from system packages to building from source.

This change is part of a larger architectural shift from using system-provided HDF5 packages to building from source, which can provide better control over the build configuration and help resolve Docker build issues.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3c29f3 and 712fada.

⛔ Files ignored due to path filters (1)

hack/docker/gen/main.go is excluded by !**/gen/**

📒 Files selected for processing (6)

Makefile.d/tools.mk (1 hunks)
dockers/ci/base/Dockerfile (0 hunks)
dockers/dev/Dockerfile (0 hunks)
dockers/example/client/Dockerfile (0 hunks)
dockers/tools/benchmark/job/Dockerfile (0 hunks)
dockers/tools/cli/loadtest/Dockerfile (0 hunks)

💤 Files with no reviewable changes (5)

dockers/example/client/Dockerfile
dockers/ci/base/Dockerfile
dockers/tools/cli/loadtest/Dockerfile
dockers/tools/benchmark/job/Dockerfile
dockers/dev/Dockerfile

vdaas-ci · 2025-01-31T04:31:43Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Fix docker build error (benchmark-job, loadtest) (#2819)

712fada

* 💚 Add libcurl4-openssl-dev Signed-off-by: vankichi <[email protected]> * ♻️ Remove apt get libhd5-dev Signed-off-by: vankichi <[email protected]> --------- Signed-off-by: vankichi <[email protected]>

coderabbitai bot reviewed Jan 31, 2025

View reviewed changes

coderabbitai bot approved these changes Jan 31, 2025

View reviewed changes

github-actions bot added area/makefile size/XXXL labels Jan 31, 2025

github-actions bot added the priority/low label Jan 31, 2025

vankichi approved these changes Jan 31, 2025

View reviewed changes

vankichi merged commit 39ed0f2 into release/v1.7 Jan 31, 2025
188 of 190 checks passed

vankichi deleted the backport/release/v1.7/bugfix/docker/fix-benchmark-job-and-loadtest-build-err branch January 31, 2025 05:28

github-actions bot mentioned this pull request Feb 1, 2025

Monthly review time metrics report: 2025-01-01..2025-01-31 #2827

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport PR #2819 to release/v1.7 for Fix docker build error (benchmark-job, loadtest) #2826

Backport PR #2819 to release/v1.7 for Fix docker build error (benchmark-job, loadtest) #2826

vdaas-ci commented Jan 31, 2025 •

edited by coderabbitai bot

Loading

cloudflare-workers-and-pages bot commented Jan 31, 2025 •

edited

Loading

coderabbitai bot commented Jan 31, 2025 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Suggested Labels

Suggested Reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

vdaas-ci commented Jan 31, 2025

Backport PR #2819 to release/v1.7 for Fix docker build error (benchmark-job, loadtest) #2826

Backport PR #2819 to release/v1.7 for Fix docker build error (benchmark-job, loadtest) #2826

Conversation

vdaas-ci commented Jan 31, 2025 • edited by coderabbitai bot Loading

Description

Related Issue

Versions

Checklist

Special notes for your reviewer

Summary by CodeRabbit

cloudflare-workers-and-pages bot commented Jan 31, 2025 • edited Loading

Deploying vald with Cloudflare Pages

coderabbitai bot commented Jan 31, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested Labels

Suggested Reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

vdaas-ci commented Jan 31, 2025

vdaas-ci commented Jan 31, 2025 •

edited by coderabbitai bot

Loading

cloudflare-workers-and-pages bot commented Jan 31, 2025 •

edited

Loading

coderabbitai bot commented Jan 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)