Merge branch 'release/2.5.2'

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 2.5.2
+
+* Fix bug that causes re-writing the redirect rules file when hits are updated
+
 # 2.5.1
 
 * Fixes issues with redirect rules file not being present

classes/StatisticsHelper.php

@@ -201,18 +201,17 @@ public function increaseHitsForRedirect(int $redirectId): void
 
         $now = Carbon::now();
 
-        RedirectObserver::startHandleChanges();
+        RedirectObserver::stopHandleChanges();
 
         /** @noinspection PhpUndefinedClassInspection */
         $redirect->forceFill([
             'hits' => DB::raw('hits + 1'),
             'last_used_at' => $now,
         ]);
 
-
         $redirect->forceSave();
 
-        RedirectObserver::stopHandleChanges();
+        RedirectObserver::startHandleChanges();
 
         $crawlerDetect = new CrawlerDetect();
 

controllers/Redirects.php

@@ -27,6 +27,7 @@
 use Vdlp\Redirect\Classes\Exceptions\InvalidScheme;
 use Vdlp\Redirect\Classes\Exceptions\NoMatchForRequest;
 use Vdlp\Redirect\Classes\Exceptions\UnableToLoadRules;
+use Vdlp\Redirect\Classes\Observers\RedirectObserver;
 use Vdlp\Redirect\Classes\RedirectManager;
 use Vdlp\Redirect\Classes\RedirectRule;
 use Vdlp\Redirect\Classes\StatisticsHelper;
@@ -282,6 +283,8 @@ public function index_onResetAllStatistics(): array
     {
         $redirectIds = $this->getAllRedirectIds();
 
+        RedirectObserver::stopHandleChanges();
+
         Models\Redirect::query()->update(['hits' => 0]);
         Models\Client::query()->delete();
 

updates/version.yaml

@@ -73,3 +73,5 @@
     - "Add support for using relative paths -- See: https://github.com/vdlp/oc-redirect-plugin/releases/tag/2.5.0"
 2.5.1:
     - "Fixes issues with redirect rules file not being present -- See: https://github.com/vdlp/oc-redirect-plugin/releases/tag/2.5.1"
+2.5.2:
+    - "Fix bug that causes re-writing the redirect rules file when hits are updated -- See: https://github.com/vdlp/oc-redirect-plugin/releases/tag/2.5.2"