Fix strpos() type error

vdlp · Oct 5, 2021 · ea79a0e · ea79a0e
1 parent 9b83ad0
commit ea79a0e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 2.5.12
+
+* Fix strpos() type error.
+
 ## 2.5.11
 
 * Fix bad use of import.

diff --git a/classes/RedirectManager.php b/classes/RedirectManager.php
@@ -239,7 +239,8 @@ public function getLocation(RedirectRule $rule)
                 break;
         }
 
-        if ($rule->getToScheme() !== Models\Redirect::SCHEME_AUTO
+        if (is_string($toUrl)
+            && $rule->getToScheme() !== Models\Redirect::SCHEME_AUTO
             && (strpos($toUrl, 'http://') === 0 || strpos($toUrl, 'https://') === 0)
         ) {
             $toUrl = str_replace(['https://', 'http://'], $rule->getToScheme() . '://', $toUrl);

diff --git a/updates/version.yaml b/updates/version.yaml
@@ -93,3 +93,5 @@
     - "Add PHP 8.0 version constraint and composer/installers package"
 2.5.11:
     - "Minor fixes -- See: https://github.com/vdlp/oc-redirect-plugin/releases/tag/2.5.11"
+2.5.12:
+    - "Fix strpos() type error"