Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: integrate codecov #630

Merged
merged 1 commit into from
Dec 27, 2023
Merged

ci: integrate codecov #630

merged 1 commit into from
Dec 27, 2023

Conversation

libotony
Copy link
Member

Also added go 1.21.x to GitHub action flow

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@qianbin
Copy link
Member

qianbin commented Dec 20, 2023

1.18 can be abandoned

@darrenvechain
Copy link
Member

darrenvechain commented Dec 20, 2023

@libotony should we enforce a minimum threshold in the CI ?

@libotony
Copy link
Member Author

@libotony should we enforce a minimum threshold in the CI ?

Do you mean the threshold for code coverage?

@darrenvechain
Copy link
Member

@libotony should we enforce a minimum threshold in the CI ?

Do you mean the threshold for code coverage?

Ya exactly

@libotony
Copy link
Member Author

@libotony should we enforce a minimum threshold in the CI ?

Do you mean the threshold for code coverage?

Ya exactly

I don't know how but it's a good to-have feature, we can set it after we top up the overall coverage.

@libotony libotony merged commit abf1da4 into vechain:master Dec 27, 2023
7 checks passed
@libotony libotony deleted the dev branch December 27, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants