-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docker build not working with sqlite #648
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
==========================================
+ Coverage 55.09% 55.16% +0.07%
==========================================
Files 179 179
Lines 20665 20680 +15
==========================================
+ Hits 11386 11409 +23
+ Misses 8442 8433 -9
- Partials 837 838 +1 ☔ View full report in Codecov by Sentry. |
LGTM, @qianbin please take a look. Source mattn/go-sqlite3#1164 (comment), and we have identified the failed test is caused by the |
This PR looks tough. Great job! |
Description
Docker build was failing on the latest golang:alpine image. This PR updates the problematic dependency and updates the event queries accordingly.
I updated
github.com/mattn/go-sqlite3
tov1.14.19
as this was the problem. Unit test then started to fail becauseORDER BY
does not seem to work in sub-clauses anymoreType of change
How Has This Been Tested?
package:
logdb_test
TestNewestBlockID
TestEvents
Manually tested
/log
endpoints to ensure results were correctly orderedTest Configuration:
go1.21.3 darwin/arm64
MacOS
24.0.6
Checklist:
/log
endpoints to ensure tho ordering still works