Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds poa/candidate tests #651

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Adds poa/candidate tests #651

merged 1 commit into from
Jan 16, 2024

Conversation

ahasikos
Copy link
Contributor

Description

This PR adds tests to poa/candidates. The code coverage exceeds the 80% target.

@libotony
A question that i have is about the func (c *Candidates) Copy() *Candidates which doesn't seem to perform a deep copy. Is it intentional?

Fixes # Code Coverage :: poa#30

How Has This Been Tested?

make test-coverage

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@ahasikos ahasikos requested a review from a team as a code owner January 11, 2024 13:20
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbe9923) 55.09% compared to head (cf6af7a) 55.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
+ Coverage   55.09%   55.35%   +0.25%     
==========================================
  Files         179      179              
  Lines       20665    20665              
==========================================
+ Hits        11386    11439      +53     
+ Misses       8442     8385      -57     
- Partials      837      841       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@libotony
Copy link
Member

libotony commented Jan 16, 2024

@libotony A question that i have is about the func (c *Candidates) Copy() *Candidates which doesn't seem to perform a deep copy. Is it intentional?

Yes, check the following file

// something like COW

@libotony libotony merged commit 09e5903 into vechain:master Jan 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants