Rename best to latest

api/blocks/blocks.go

@@ -23,6 +23,8 @@
 	bft  BFTEngine
 }
 
+const BEST_BLOCK_NAME = "latest"
+
 func New(repo *chain.Repository, bft BFTEngine) *Blocks {
 	return &Blocks{
 		repo,
@@ -85,7 +87,7 @@
 }
 
 func (b *Blocks) parseRevision(revision string) (interface{}, error) {
-	if revision == "" || revision == "best" {
+	if revision == "" || revision == BEST_BLOCK_NAME {
 		return nil, nil
 	}
 	if revision == "finalized" {

api/blocks/blocks_test.go

@@ -64,7 +64,7 @@ func TestBlock(t *testing.T) {
 	checkBlock(t, blk, rb)
 	assert.Equal(t, http.StatusOK, statusCode)
 
-	res, statusCode = httpGet(t, ts.URL+"/blocks/best")
+	res, statusCode = httpGet(t, ts.URL+"/blocks/latest")
 	if err := json.Unmarshal(res, &rb); err != nil {
 		t.Fatal(err)
 	}

api/debug/debug.go

@@ -17,6 +17,7 @@
 	"github.com/ethereum/go-ethereum/rlp"
 	"github.com/gorilla/mux"
 	"github.com/pkg/errors"
+	"github.com/vechain/thor/v2/api/blocks"
 	"github.com/vechain/thor/v2/api/utils"
 	"github.com/vechain/thor/v2/chain"
 	"github.com/vechain/thor/v2/consensus"
@@ -354,7 +355,7 @@
 }
 
 func (d *Debug) handleRevision(revision string) (*chain.BlockSummary, error) {
-	if revision == "" || revision == "best" {
+	if revision == "" || revision == blocks.BEST_BLOCK_NAME {
 		return d.repo.BestBlockSummary(), nil
 	}
 	if len(revision) == 66 || len(revision) == 64 {

api/doc/thor.yaml

@@ -270,7 +270,7 @@ paths:
         - Blocks
       summary: Retrieve block
       description: |
-        by ID or number, or 'best' for latest block or 'finalized' for finalized block. If `expanded` query option is true, all transactions along with
+        by ID or number, or 'latest' for latest block or 'finalized' for finalized block. If `expanded` query option is true, all transactions along with
         their receipts will be embedded under `transactions` field instead of ids.
       responses:
         '200':
@@ -1392,24 +1392,24 @@ components:
     RevisionInQuery:
       name: revision
       in: query
-      description: can be block number or ID. best block is assumed if omitted.
+      description: can be block number or ID. latest block is assumed if omitted.
       schema:
         type: string
 
     RevisionInPath:
       name: revision
       in: path
       description: |
-        block ID or number, or 'best' stands for latest block, or 'finalized' stands for finalized block
+        block ID or number, or 'latest' stands for latest block, or 'finalized' stands for finalized block
       required: true
       schema:
         type: string
-      example: best
+      example: latest
 
     HeadInQuery:
       name: head
       in: query
-      description: ID of head block. best block is assumed if omitted
+      description: ID of head block. latest block is assumed if omitted
       schema:
         type: string
 
@@ -1457,7 +1457,7 @@ components:
       name: pos
       in: query
       description: |
-        a saved block ID for resuming the subscription. best block ID is assumed if omitted.
+        a saved block ID for resuming the subscription. latest block ID is assumed if omitted.
       schema:
         type: string
 

chain/repository.go

@@ -103,7 +103,7 @@ func NewRepository(db *muxdb.MuxDB, genesis *block.Block) (*Repository, error) {
 		}
 
 		if summary, err := repo.GetBlockSummary(bestID); err != nil {
-			return nil, errors.Wrap(err, "get best block")
+			return nil, errors.Wrap(err, "get latest block")
 		} else {
 			repo.bestSummary.Store(summary)
 		}

cmd/thor/flags.go

@@ -53,7 +53,7 @@ var (
 	apiBacktraceLimitFlag = cli.IntFlag{
 		Name:  "api-backtrace-limit",
 		Value: 1000,
-		Usage: "limit the distance between 'position' and best block for subscriptions APIs",
+		Usage: "limit the distance between 'position' and latest block for subscriptions APIs",
 	}
 	apiAllowCustomTracerFlag = cli.BoolFlag{
 		Name:  "api-allow-custom-tracer",

cmd/thor/node/packer_loop.go

@@ -97,7 +97,7 @@ func (n *Node) packerLoop(ctx context.Context) {
 
 				if (best.Number() == flow.ParentHeader().Number() && s1 != s2) ||
 					best.TotalScore() > flow.TotalScore() {
-					log.Debug("re-schedule packer due to new best block")
+					log.Debug("re-schedule packer due to new latest block")
 					goto RE_SCHEDULE
 				}
 			}

cmd/thor/solo/solo.go

@@ -165,7 +165,7 @@ func (s *Solo) packing(pendingTxs tx.Transactions, onDemand bool) error {
 	realElapsed := mclock.Now() - startTime
 
 	if err := s.repo.SetBestBlockID(b.Header().ID()); err != nil {
-		return errors.WithMessage(err, "set best block")
+		return errors.WithMessage(err, "set latest block")
 	}
 
 	if !s.skipLogs {

cmd/thor/utils.go

@@ -538,12 +538,12 @@ func printStartupMessage1(
 	bestBlock := repo.BestBlockSummary()
 
 	fmt.Printf(`Starting %v
-    Network      [ %v %v ]
-    Best block   [ %v #%v @%v ]
-    Forks        [ %v ]
-    Master       [ %v ]
-    Beneficiary  [ %v ]
-    Instance dir [ %v ]
+    Network        [ %v %v ]
+    Latest block   [ %v #%v @%v ]
+    Forks          [ %v ]
+    Master         [ %v ]
+    Beneficiary    [ %v ]
+    Instance dir   [ %v ]
 `,
 		common.MakeName("Thor", fullVersion()),
 		gene.ID(), gene.Name(),
@@ -592,11 +592,11 @@ func printSoloStartupMessage(
 	bestBlock := repo.BestBlockSummary()
 
 	info := fmt.Sprintf(`Starting %v
-    Network     [ %v %v ]    
-    Best block  [ %v #%v @%v ]
-    Forks       [ %v ]
-    Data dir    [ %v ]
-    API portal  [ %v ]
+    Network       [ %v %v ]    
+    Latest block  [ %v #%v @%v ]
+    Forks         [ %v ]
+    Data dir      [ %v ]
+    API portal    [ %v ]
 ┌──────────────────┬───────────────────────────────────────────────────────────────────────────────┐
 │  Mnemonic Words  │  denial kitchen pet squirrel other broom bar gas better priority spoil cross  │
 └──────────────────┴───────────────────────────────────────────────────────────────────────────────┘

comm/communicator.go

@@ -105,7 +105,7 @@ func (c *Communicator) Sync(ctx context.Context, handler HandleBlockStream) {
 					break
 				}
 				// if more than 3 peers connected, we are assumed to be the best
-				log.Debug("synchronization done, best assumed")
+				log.Debug("synchronization done, latest assumed")
 			} else {
 				if err := download(ctx, c.repo, peer, best.Number(), handler); err != nil {
 					peer.logger.Debug("synchronization failed", "err", err)

logdb/logdb_test.go

@@ -278,7 +278,7 @@ func TestLogDB_NewestBlockID(t *testing.T) {
 				return b.Header().ID(), nil
 			},
 		}, {
-			"add empty block, best should remain unchanged",
+			"add empty block, latest should remain unchanged",
 			func() (thor.Bytes32, error) {
 				wanted := b.Header().ID()
 				b = new(block.Builder).ParentID(b.Header().ID()).Build()
@@ -295,7 +295,7 @@ func TestLogDB_NewestBlockID(t *testing.T) {
 			},
 		},
 		{
-			"add both event and transfer, best should change",
+			"add both event and transfer, latest should change",
 			func() (thor.Bytes32, error) {
 				b = new(block.Builder).
 					ParentID(b.Header().ID()).