-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Metrics to the node #671
Conversation
Hiya, can the swagger docs be updated and the README updated about that also? cheers |
Updated ! Also, upon review of the swagger I think it becomes clear that this endpoint should live under the |
205d7cc
to
02a60dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
==========================================
+ Coverage 61.87% 61.89% +0.01%
==========================================
Files 199 202 +3
Lines 18318 18696 +378
==========================================
+ Hits 11335 11572 +237
- Misses 5880 6013 +133
- Partials 1103 1111 +8 ☔ View full report in Codecov by Sentry. |
bc173fd
to
b14196e
Compare
@darrenvechain does anything need to be done in order to support this via stoplight? |
Nope, it's all configured via Open API spec, which is compatible with swagger and stoplight |
0c00dda
to
04ce5d1
Compare
Co-authored-by: libotony <[email protected]>
Co-authored-by: libotony <[email protected]>
* move metric/size to thor * rename telemetry related flags to metrics and a refactor to start up message * rename package telemetry to metrics * Update cmd/thor/flags.go Co-authored-by: Pedro Gomes <[email protected]> --------- Co-authored-by: Pedro Gomes <[email protected]>
* tweak metrics in txpool and node * move metrics in bft to seperate file * identify block proposed/received for metrics processed tx/gas * promote bft rejected error && pr comments
1b79eb1
to
8d87599
Compare
Description
OpenTelemetry Metrics/ Prometheus Metrics to thor/node/metrics
endpoint with metrics for the nodeenable-telemetry
flag set to true (defaults to false)Type of change
How Has This Been Tested?
Unit tests in the code.
Checklist: