Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage api package [accounts, blocks, events, node, transactions, transfers] #681

Merged
merged 20 commits into from
Apr 22, 2024

Conversation

paologalligit
Copy link
Member

Description

Added more tests to reach 80% of test coverage on api packages:

  • accounts
  • blocks
  • events
  • node
  • transactions
  • transfers

Type of change

  • Test coverage

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@paologalligit paologalligit requested a review from a team as a code owner March 20, 2024 16:41
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 59.16%. Comparing base (c9c4a51) to head (8af7c22).
Report is 4 commits behind head on master.

❗ Current head 8af7c22 differs from pull request most recent head d903f1f. Consider uploading reports for the commit d903f1f to get more accurate results

Files Patch % Lines
thor/bytes32.go 0.00% 2 Missing ⚠️
chain/chain.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   57.27%   59.16%   +1.88%     
==========================================
  Files         156      156              
  Lines       17218    17218              
==========================================
+ Hits         9862    10187     +325     
+ Misses       6392     6076     -316     
+ Partials      964      955       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paologalligit paologalligit requested a review from libotony March 28, 2024 11:56
thor/bytes32.go Outdated Show resolved Hide resolved
@paologalligit paologalligit requested a review from libotony April 8, 2024 14:52
chain/repository.go Outdated Show resolved Hide resolved
@paologalligit paologalligit requested a review from libotony April 16, 2024 09:55
@libotony libotony added the next release candidate Ok to merge for next release label Apr 16, 2024
@otherview otherview merged commit 1ed5a6a into vechain:master Apr 22, 2024
10 checks passed
@paologalligit paologalligit deleted the test_coverage branch May 3, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release candidate Ok to merge for next release testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants