Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase bandwidth coverage #727

Merged
merged 7 commits into from
Jun 26, 2024

Conversation

MakisChristou
Copy link
Contributor

Increases bandwith.go coverage to 84%. Relevant issue.

@MakisChristou MakisChristou requested a review from a team as a code owner April 30, 2024 07:22
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.55%. Comparing base (e61c650) to head (02a187f).
Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   61.35%   62.55%   +1.20%     
==========================================
  Files         194      199       +5     
  Lines       18221    18140      -81     
==========================================
+ Hits        11179    11348     +169     
+ Misses       5960     5708     -252     
- Partials     1082     1084       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@paologalligit paologalligit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing, remove also the whitespaces the linter is complaining about, so we're good to merge it

paologalligit
paologalligit previously approved these changes Jun 14, 2024
Copy link
Member

@paologalligit paologalligit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the comment, then it's ready to be merged 👍

libotony
libotony previously approved these changes Jun 25, 2024
@libotony libotony self-requested a review June 25, 2024 10:17
@libotony libotony merged commit 5d05048 into vechain:master Jun 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants