fix health condition

health/health.go

@@ -47,8 +47,7 @@ func (h *Health) Status() (*Status, error) {
 		BestBlockIngestionTimestamp: &h.newBestBlock,
 	}
 
-	// todo review time slots
-	healthy := time.Since(h.newBestBlock) >= 10*time.Second &&
+	healthy := time.Since(h.newBestBlock) <= 10*time.Second && // less than 10 secs have passed since a new block was received
 		h.chainSynced
 
 	return &Status{

health/health_test.go

@@ -0,0 +1,85 @@
+// Copyright (c) 2024 The VeChainThor developers
+
+// Distributed under the GNU Lesser General Public License v3.0 software license, see the accompanying
+// file LICENSE or <https://www.gnu.org/licenses/lgpl-3.0.html>
+
+package health
+
+import (
+	"testing"
+	"time"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"github.com/vechain/thor/v2/thor"
+)
+
+func TestHealth_NewBestBlock(t *testing.T) {
+	h := &Health{}
+	blockID := thor.Bytes32{0x01, 0x02, 0x03}
+
+	h.NewBestBlock(blockID)
+
+	if h.bestBlockID == nil || *h.bestBlockID != blockID {
+		t.Errorf("expected bestBlockID to be %v, got %v", blockID, h.bestBlockID)
+	}
+
+	if time.Since(h.newBestBlock) > time.Second {
+		t.Errorf("newBestBlock timestamp is not recent")
+	}
+
+	h.ChainSyncStatus(true)
+
+	status, err := h.Status()
+	require.NoError(t, err)
+
+	assert.True(t, status.Healthy)
+}
+
+func TestHealth_ChainSyncStatus(t *testing.T) {
+	h := &Health{}
+
+	h.ChainSyncStatus(true)
+	if !h.chainSynced {
+		t.Errorf("expected chainSynced to be true, got false")
+	}
+
+	h.ChainSyncStatus(false)
+	if h.chainSynced {
+		t.Errorf("expected chainSynced to be false, got true")
+	}
+
+	status, err := h.Status()
+	require.NoError(t, err)
+
+	assert.False(t, status.Healthy)
+}
+
+func TestHealth_Status(t *testing.T) {
+	h := &Health{}
+	blockID := thor.Bytes32{0x01, 0x02, 0x03}
+
+	h.NewBestBlock(blockID)
+	h.ChainSyncStatus(true)
+
+	status, err := h.Status()
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+
+	if !status.Healthy {
+		t.Errorf("expected healthy to be true, got false")
+	}
+
+	if status.BlockIngestion.BestBlock == nil || *status.BlockIngestion.BestBlock != blockID {
+		t.Errorf("expected bestBlock to be %v, got %v", blockID, status.BlockIngestion.BestBlock)
+	}
+
+	if status.BlockIngestion.BestBlockIngestionTimestamp == nil || time.Since(*status.BlockIngestion.BestBlockIngestionTimestamp) > time.Second {
+		t.Errorf("bestBlockIngestionTimestamp is not recent")
+	}
+
+	if !status.ChainSync {
+		t.Errorf("expected chainSync to be true, got false")
+	}
+}