Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to thorclient #920

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fixes to thorclient #920

merged 1 commit into from
Dec 12, 2024

Conversation

otherview
Copy link
Member

Description

This includes some fixes to thorclient.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@otherview otherview requested a review from a team as a code owner December 12, 2024 14:15
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.83%. Comparing base (5fe421e) to head (4ebd888).

Files with missing lines Patch % Lines
thorclient/thorclient.go 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
+ Coverage   60.69%   60.83%   +0.14%     
==========================================
  Files         219      219              
  Lines       23374    23383       +9     
==========================================
+ Hits        14186    14225      +39     
+ Misses       8025     7994      -31     
- Partials     1163     1164       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@otherview otherview merged commit dcea741 into master Dec 12, 2024
15 checks passed
@otherview otherview deleted the pedro/thorclient_updates branch December 12, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants