157 create a better flow when a certificate is required for wallet connect #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidecarpini
changed the title
|
@davidecarpini do you think we could add a spinner or some indication that the modal is waiting for user interaction in their wallet? |
|
@darrenvechain yeah definitely |
…-2' of https://github.com/vechain/vechain-dapp-kit into 157-create-a-better-flow-when-a-certificate-is-required-2
|
added loader Screen.Recording.2024-01-11.at.16.30.26.mov |
Can we also have this when we click |
|
what do you think @darrenvechain ? with-require-certificate.movwithout-require-certificate.mov |
darrenvechain
approved these changes
Jan 11, 2024
davidecarpini
deleted the
157-create-a-better-flow-when-a-certificate-is-required-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-01-11.at.13.14.20.mov