Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test-testid #238

Merged
merged 2 commits into from
Apr 29, 2024
Merged

chore: add test-testid #238

merged 2 commits into from
Apr 29, 2024

Conversation

claytonneal
Copy link
Member

@claytonneal claytonneal commented Apr 25, 2024

Add data-testid on source-card component and also disconnect button
Tools like playwright can query the shadow dom on this attribute and easily click on VeWorld for example

fixes: #220

reference: https://playwright.dev/docs/locators#locate-in-shadow-dom

@davidecarpini davidecarpini merged commit 9f14b80 into main Apr 29, 2024
4 checks passed
@davidecarpini davidecarpini deleted the chore/data-testid branch April 29, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ids to ui elements
2 participants