Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding signed typed data #286

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Adding signed typed data #286

merged 6 commits into from
Oct 9, 2024

Conversation

Valazan
Copy link
Collaborator

@Valazan Valazan commented Oct 3, 2024

Adding the signed Typed data to the DappKit

@Valazan Valazan marked this pull request as draft October 3, 2024 13:54
Copy link

socket-security bot commented Oct 3, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] network 0 12.6 MB ricmoo

View full report↗︎

@Valazan Valazan marked this pull request as ready for review October 7, 2024 09:26
Copy link
Member

@davidecarpini davidecarpini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM added some comments to check

packages/dapp-kit/src/classes/certificate-wallet.ts Outdated Show resolved Hide resolved
packages/dapp-kit/src/classes/certificate-wallet.ts Outdated Show resolved Hide resolved
packages/dapp-kit/src/classes/wc-wallet.ts Outdated Show resolved Hide resolved
@davidecarpini davidecarpini enabled auto-merge (squash) October 8, 2024 09:32
@davidecarpini davidecarpini merged commit acde52d into main Oct 9, 2024
8 checks passed
@davidecarpini davidecarpini deleted the adding-signed-typed-data branch October 9, 2024 10:28
fabiorigam added a commit that referenced this pull request Dec 17, 2024
* 266 use sdk instead of thor devkit (#267)

* feat: working tests

* feat: remove thor-devkit

* fix: e2e tests

* fix: tests

* Refactor inputs (#268)

* fix: refactor inputs

* fix: improve inputs

* Sonar integration (#254)

* Create sonar-scan.yml

* Create sonar-project.properties

* remove test branch from workflow

---------

Co-authored-by: Fabio Rigamonti <[email protected]>

* Bump 1.0.13 (#269)

* chore: v1.0.13

* fix: versions

* Update README.md (#273)

* fix: update README.md

* fix: update LICENSE

* Adding signed typed data (#286)

* feat: adding signer typed data with connex

* feat: expose signedTypedData

* feat: revert changes to dappKit Driver

* test: sign typed data

* fix: linting

* refactor: simplify signTypedData method in certificate-wallet and wc-wallet

* build: v1.0.14 (#287)

* fix: strict mode issue (#288)

* chore(deps): bump vite from 5.3.5 to 5.3.6 (#279)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.3.5 to 5.3.6.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.3.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.3.6/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Davide Carpini <[email protected]>

* chore(deps): bump next in /examples/sample-next-app (#280)

Bumps [next](https://github.com/vercel/next.js) from 14.1.4 to 14.2.10.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v14.1.4...v14.2.10)

---
updated-dependencies:
- dependency-name: next
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Davide Carpini <[email protected]>

* chore(deps): bump express from 4.19.2 to 4.21.0 (#281)

Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Davide Carpini <[email protected]>

* chore(deps-dev): bump vite from 4.5.3 to 4.5.5 (#289)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.5.3 to 4.5.5.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.5/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.5/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: version bump 1.0.15 (#290)

* Add vechain domains (#293)

* feat: add vns domains on react

* fix: configs

* fix: vanilla button and modal

* fix: react stuff

* fix: improved tests

* fix: eslint

* fix: package json

* fix: yarn lock

* fix: build

* fix: eslint

* chore(deps): bump http-proxy-middleware from 2.0.6 to 2.0.7 (#294)

Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.6 to 2.0.7.
- [Release notes](https://github.com/chimurai/http-proxy-middleware/releases)
- [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.7/CHANGELOG.md)
- [Commits](chimurai/http-proxy-middleware@v2.0.6...v2.0.7)

---
updated-dependencies:
- dependency-name: http-proxy-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Davide Carpini <[email protected]>

* feat: allow custom net injection (#257)

Co-authored-by: Fabio Rigamonti <[email protected]>
Co-authored-by: Davide Carpini <[email protected]>

* feat: ping wallet connect on focus (#224)

* feat: ping wallet connect on focus

* fix: if statement for ssr

* fix: update yarn.lock

---------

Co-authored-by: Fabio Rigamonti <[email protected]>
Co-authored-by: Davide Carpini <[email protected]>

* Chore/v1.0.16 (#295)

* chore: v1.0.16

* chore: v1.0.16

* chore: sdk to beta 32

* fix: angular typescript version

* fix: typescript

* fix: add wallets filter

* chore: review build process

* fix: publish packages script

* fix: publish packages script

* fix: publish packages script

* V1.1.0 (#299)

* chore: review build process

* fix: publish packages script

* fix: publish packages script

* chore(release): v1.1.0

* fix: publish script

* fix: useVechainDomain

* fix: decouple fetch vechain domain

* chore(release): v1.1.1

* fix: prepare packages script (#306)

* chore(deps-dev): bump happy-dom from 14.12.3 to 15.10.2 (#309)

Bumps [happy-dom](https://github.com/capricorn86/happy-dom) from 14.12.3 to 15.10.2.
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v14.12.3...v15.10.2)

---
updated-dependencies:
- dependency-name: happy-dom
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fabio Rigamonti <[email protected]>

* chore(deps): bump @eslint/plugin-kit from 0.2.1 to 0.2.3 (#312)

Bumps [@eslint/plugin-kit](https://github.com/eslint/rewrite) from 0.2.1 to 0.2.3.
- [Release notes](https://github.com/eslint/rewrite/releases)
- [Changelog](https://github.com/eslint/rewrite/blob/main/release-please-config.json)
- [Commits](eslint/rewrite@plugin-kit-v0.2.1...plugin-kit-v0.2.3)

---
updated-dependencies:
- dependency-name: "@eslint/plugin-kit"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fabio Rigamonti <[email protected]>

* fix: merge conflicts

* fix: fix failing tests

* fix: remove duplicated constants

* fix: remove unused files

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Davide Carpini <[email protected]>
Co-authored-by: WaqarAhmedVC <[email protected]>
Co-authored-by: Valazan <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Darren Kelly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants